From 2cc385b71e161eae39915bf24de53d5b704e7ea0 Mon Sep 17 00:00:00 2001 From: Andrew Opalach Date: Tue, 5 Aug 2025 10:50:08 -0400 Subject: Twitter module work, various cleanups and comment clarifications Signed-off-by: Andrew Opalach --- src/liana/handlers/codec_server.c | 2 +- src/liana/list.c | 3 +++ src/liana/vcr.c | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) (limited to 'src/liana') diff --git a/src/liana/handlers/codec_server.c b/src/liana/handlers/codec_server.c index 3b7d31e..c324481 100644 --- a/src/liana/handlers/codec_server.c +++ b/src/liana/handlers/codec_server.c @@ -58,7 +58,7 @@ static void codec_server_write_info(struct lia_server_handler *handler, struct n nn_packet_write_u8(packet, stream->mode); nn_packet_write_u8(packet, stream->type); nn_packet_write_u64(packet, stream->duration); - // stream->index = i is currently expected but not necessary. + // stream->index = i is currently expected but shouldn't be (and isn't) relied upon anywhere. al_assert(stream->index == (s32)i); nn_packet_write_s32(packet, stream->index); switch (stream->mode) { diff --git a/src/liana/list.c b/src/liana/list.c index 610ee80..42fcb91 100644 --- a/src/liana/list.c +++ b/src/liana/list.c @@ -287,6 +287,9 @@ static bool handle_skipto(struct lia_list *list, s32 sequence, s32 index) // Target was never started before. target->start = at; } else { + // @TODO: I've observed this tripping when target->ended is true. + // Possibly related to clients having network latency and/or high video processing load. + // Maybe also exclusive to SINK_LOCAL mode. // Target is paused or static. al_assert(target->duration == 0 || target->paused_at != LIANA_TIMESTAMP_INVALID); } diff --git a/src/liana/vcr.c b/src/liana/vcr.c index 352fb03..518311a 100644 --- a/src/liana/vcr.c +++ b/src/liana/vcr.c @@ -67,7 +67,7 @@ static nn_thread_result NNWT_THREADCALL vcr_track_thread(void *userdata) struct lia_vcr_track *track = (struct lia_vcr_track *)userdata; struct lia_vcr *vcr = track->vcr; const char thread_name[16] = "\0"; // 16 = limit. - al_snprintf((char *)thread_name, sizeof(thread_name), "vcr:%hu", vcr->node_id); + al_snprintf((char *)thread_name, sizeof(thread_name), "vcr:%hu_%hu", vcr->node_id, track->stream->index); nn_thread_set_name(thread_name); s32 state; -- cgit v1.2.3-101-g0448